ci: add production workflow #1019
Conversation
.github/workflows/ci-cd-prod.yml
Outdated
| function-project-path: "./src/Digdir.Tool.Dialogporten.SlackNotifier" | ||
| environment: prod | ||
|
|
||
| run-e2e-tests: |
There was a problem hiding this comment.
Do we want to run this in production? Would be sweet to be able to, but is it safe atm?
There was a problem hiding this comment.
@elsand hva tenker du?
There was a problem hiding this comment.
Her er mine umiddelbare tanker. Sist gang jeg så testene mener jeg å huske at de for det første skrev til Dialogporten, og for det andre at de gjorde det på test ressurser (fra ressurs registeret i test). Vil de i det hele tatt kjøre? Tror egentlig vi heller burde ha et flyktig miljø å kjøre disse i før vi i det hele tatt får lov til å publisere til prod.
There was a problem hiding this comment.
True true. Vi får ta en runde på det i refinement kanskje? Kan kommentere ut inntil videre!
.github/workflows/ci-cd-prod.yml
Outdated
| name: Get current version | ||
| uses: ./.github/workflows/action-get-current-version.yml | ||
|
|
||
| # todo: should not need to re-build and re-publish the image here. Use existing image instead |
There was a problem hiding this comment.
Skal dette gjøres som del av denne PRen eller en annen? Har vi i så fall et issue på det?
There was a problem hiding this comment.
Yess godt poeng. Lagde et issue på det nå. #1023
.github/workflows/ci-cd-prod.yml
Outdated
| function-project-path: "./src/Digdir.Tool.Dialogporten.SlackNotifier" | ||
| environment: prod | ||
|
|
||
| run-e2e-tests: |
There was a problem hiding this comment.
Her er mine umiddelbare tanker. Sist gang jeg så testene mener jeg å huske at de for det første skrev til Dialogporten, og for det andre at de gjorde det på test ressurser (fra ressurs registeret i test). Vil de i det hele tatt kjøre? Tror egentlig vi heller burde ha et flyktig miljø å kjøre disse i før vi i det hele tatt får lov til å publisere til prod.
|
Description
Will run a dry-run of the deployment to both infra and apps on a new release. Will have to be reviewed manually before deployment happens.
We now have a full workflow for deployment to production. Some time in the not so very near future, I think it would be wise to split up the dry-run part and the deployment itself. As right now it would require a review from any of us to even start the dry-run, which should happen automatically on every release.
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)