Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show success message when observations export finishes #622

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 9, 2021

Closes #319

Notes:

  • Potential add to this PR is improve error handling by showing some sort of error message if it occurs

Preview:

319-export-success-dialog

@achou11 achou11 requested review from gmaclennan and ErikSin November 9, 2021 19:25
@achou11 achou11 force-pushed the ac/319/export-success-dialog branch 3 times, most recently from df64b75 to 16061fb Compare November 9, 2021 19:30
@achou11 achou11 force-pushed the ac/319/export-success-dialog branch from 16061fb to b20e4ca Compare November 9, 2021 19:38
Copy link
Contributor

@ErikSin ErikSin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add typescript to this project (How did the js world do anything on the enterprise level before ts?).

Good job!

@ErikSin ErikSin merged commit 0713c5b into master Nov 9, 2021
@ErikSin ErikSin deleted the ac/319/export-success-dialog branch November 9, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Front) Observations/Give clear indication when exporting is finished
2 participants