fix: Upgrade electron builder to latest version #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Nov 22, 2021
| @@ -71,7 +71,7 @@ jobs: | |||
| MAPEO_VARIANT: ${{ matrix.variant }} | |||
| - name: Cleanup artifacts | |||
| run: | | |||
| npx rimraf@2 'dist/${{ matrix.variant }}/!(*.exe|*.deb|*.AppImage|*.dmg|*.yml|github)' | |||
| npx rimraf@2 'dist/${{ matrix.variant }}/!(*.exe|*.deb|*.AppImage|*.dmg|*.yml|*.zip|github)' | |||
There was a problem hiding this comment.
initially just changed this so I could actually download the asset from CI for testing this change, but maybe it's just worth keeping anyways
achou11
commented
Nov 22, 2021
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 12.14.1 | ||
| node-version: 14.18 |
There was a problem hiding this comment.
Think it should be okay to not be specific about patch version but happy to change if necessary
achou11
force-pushed
the
ac/625/zip-macos-fix
branch
from
66ab88a to
852c040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #625 (see builder changelog)
Tested by successfully installing the associated MacOS
zipasset generated in CINotes: