Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a name for the session #45

Open
jthoward64 opened this issue Mar 7, 2023 · 2 comments
Open

Allow setting a name for the session #45

jthoward64 opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jthoward64
Copy link

It would be nice to allow setting a friendlier name than the url + the user agent. This could be accomplished by adding an optional query param (for example session-name) and modifying this line to use that instead. I suppose there is a slight security issue if a malicious site were to try and imitate another site though. To remedy that I would suggest just prefixing the custom session name with App Password: or something. I would be willing to make a PR if you would accept it.

@pbek pbek added the enhancement New feature or request label Mar 7, 2023
@pbek
Copy link
Member

pbek commented Mar 7, 2023

Thank you for your concern. What is it you would like to achieve by this change? Improve how the generated token looks on the Nextcloud Admin page?

@jthoward64
Copy link
Author

jthoward64 commented Mar 7, 2023

Exactly, the idea would be to go from this:
msedge_vawKcZDVns
to this:
msedge_d06GiFID1n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants