Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native APIs #6

Open
davidlehn opened this issue Jun 26, 2018 · 2 comments
Open

Update native APIs #6

davidlehn opened this issue Jun 26, 2018 · 2 comments

Comments

@davidlehn
Copy link
Member

davidlehn commented Jun 26, 2018

When the native code is split out to another module (see digitalbazaar/rdf-canonize#5), also look at updating to N-API / node-addon-api. Should help with some portability issues.

https://medium.com/the-node-js-collection/native-extensions-for-node-js-767e221b3d26

@davidlehn davidlehn transferred this issue from digitalbazaar/rdf-canonize Jan 24, 2019
@mattcollier
Copy link
Contributor

Start here: https://github.com/digitalbazaar/rdf-canonize-native/tree/napi

It works, but there seemed to be a significant performance penalty vs current implementation. Hopefully it's just a matter of finding the offending code.

@davidlehn
Copy link
Member Author

Yup, thanks for referencing that. I was just trying the "transfer issue" feature since this was still in the js project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants