Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of Debug.Faile(...) in EventLogging #62

Open
mySupply opened this issue Nov 11, 2021 · 0 comments
Open

Wrong use of Debug.Faile(...) in EventLogging #62

mySupply opened this issue Nov 11, 2021 · 0 comments

Comments

@mySupply
Copy link

Hi

In the EventLogging class, the exist this kind of code

Debug.Fail("Unable to log event, exception: {0}", e.Message);

However, this will always show/print the message 'Unable to log event, exception: {0}', as nothing is inserter into the placeholder.

The code could be updated to something like this:

Debug.Fail($"Unable to log event, exception: {e.Message}", e.ToString());

or

Debug.Fail($"Unable to log event, exception: {e.Message}");

Jacob Mogensen
mysupply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant