Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exceptions more detailed #36

Closed
dimastbk opened this issue Sep 5, 2023 · 1 comment · Fixed by #51
Closed

Make exceptions more detailed #36

dimastbk opened this issue Sep 5, 2023 · 1 comment · Fixed by #51

Comments

@dimastbk
Copy link
Owner

dimastbk commented Sep 5, 2023

I think more of a design decision for Calamine but are you expecting to implement more detailed error types? If so would probably be better to use those instead of a generic error like this

Originally posted by @WillAyd in pandas-dev/pandas#54998 (comment)

@dimastbk
Copy link
Owner Author

dimastbk commented Sep 5, 2023

At least:

  • ZipError
  • XmlError
  • VbaError
  • PasswordError (?) - now only in xls
  • Io (?)

@dimastbk dimastbk changed the title Make expections more detailed Make exceptions more detailed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant