IntersectionCompositeShapeShapeVisitor is now able to return partId #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vrixyz
commented
Dec 5, 2024
•
Vrixyz
commented
- Follow up to Address a few TODOs #273 (comment) ; Thanks @wlinna!
This was referenced Dec 6, 2024
Vrixyz
commented
Dec 6, 2024
src/query/intersection_test/intersection_test_composite_shape_shape.rs
Outdated
Show resolved
Hide resolved
Vrixyz
force-pushed
the
273-shape-shape-partId
branch
from
b701f4c to
f3db16b
Compare
sebcrozet
requested changes
Dec 6, 2024
sebcrozet
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.