Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we expose scrollToIndex ? #132

Open
FilipeCosta06 opened this issue Jun 16, 2020 · 0 comments
Open

Could we expose scrollToIndex ? #132

FilipeCosta06 opened this issue Jun 16, 2020 · 0 comments

Comments

@FilipeCosta06
Copy link

Hi,

If I'm not mistaken, the scrollToIndex feature isn't exposed, only the scrollToId (I went a little more in details when I tried hijacking this closed Issue #46).

As I mentioned back there, I'm fearful the looping from scrollToId could cause serious performance drops and, considering Nodes already "know" their own index, and I have a reference to them, I think it couldn't hurt to expose scrollToIndex too. Also, the PropType seems to be wrong (again, I already detailed that in my comment).

I had tried simply exposing it myself by using the source code but I'm relatively knew to all this (especially React) and it was messed up bad (I think I wasn't resetting the value so scrolling etc... would become impossible AND I had another unrelated issue that I was fixing already ahah).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant