-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling large number of children #84
Comments
Hi @Baehn. I believe the tree supports a reasonable number of child nodes, but yes the bottleneck is I will be releasing some news on a more performant approach over the next couple of days |
Hi @Baehn Just did some work on this and by managing more state could make some fantastic improvements. This work is still unstable, so it isn't available on npm just yet, will be in the next few days. I change https://diogofcunha.github.io/react-virtualized-tree/#/examples/large-collection example to use this Unstable tree and it is rendering around 1.7 Million nodes and has you can see updates in the tree are really fast. Hope this will help you. |
great! Have you tried trees with many direct childrens? I have changed the implementation of |
@Baehn @diogofcunha from the ECMAScript 2015 document, Ref: https://www.ecma-international.org/ecma-262/6.0/#sec-array.prototype.reduce Performance test can be found here: |
@diogofcunha may I ask what is the |
Hi @Baehn. I'm aware of performance implications with reduce, although most times it doesn't really matter. The new tree implementation (Unstable) is written with for loops and an improved seek and it's much faster. Yes, there will be a stable version, I just need to find the time to play around with it a little bit more and make sure it's good enough to ship. |
Any update on when |
I'm also interested in the stable version of |
I see only exporting Tree and {selectors, renderers, constants, FilteringContainer} and so on. But UnstableFastTree is not yet, is this waiting for a stable version or how will I use it? |
Hi,
I'm trying to render tree structures having largen numbers of direct children (several thousands).
Rendering times are very slow then. I think the reason for this is the way
getFlattenedTree
is implemented.The text was updated successfully, but these errors were encountered: