Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner stroke style on ionicons #28

Closed
wadagso-gertjaap opened this issue Oct 13, 2023 · 1 comment · Fixed by #36
Closed

Inner stroke style on ionicons #28

wadagso-gertjaap opened this issue Oct 13, 2023 · 1 comment · Fixed by #36
Assignees
Labels
bug Something isn't working

Comments

@wadagso-gertjaap
Copy link

wadagso-gertjaap commented Oct 13, 2023

It seems that ionicons have inner stroke style elements - rendering all icons in black even though the stroke is set to currentColor, the inner style on the path negates it:

<svg stroke="currentColor" stroke-width="0" class="h-6 w-6" height="20" width="20" viewBox="0 0 512 512"
    xmlns="http://www.w3.org/2000/svg" fill="currentColor">
    <title></title>
    <path d="M431,320.6c-1-3.6,1.2-8.6,3.3-12.2a33.68,33.68,0,0,1,2.1-3.1A162,162,0,0,0,464,215c.3-92.2-77.5-167-173.7-167C206.4,48,136.4,105.1,120,180.9a160.7,160.7,0,0,0-3.7,34.2c0,92.3,74.8,169.1,171,169.1,15.3,0,35.9-4.6,47.2-7.7s22.5-7.2,25.4-8.3a26.44,26.44,0,0,1,9.3-1.7,26,26,0,0,1,10.1,2L436,388.6a13.52,13.52,0,0,0,3.9,1,8,8,0,0,0,8-8,12.85,12.85,0,0,0-.5-2.7Z" style="fill:none;stroke:#000;stroke-linecap:round;stroke-miterlimit:10;stroke-width:32px"></path>
    <path d="M66.46,232a146.23,146.23,0,0,0,6.39,152.67c2.31,3.49,3.61,6.19,3.21,8s-11.93,61.87-11.93,61.87a8,8,0,0,0,2.71,7.68A8.17,8.17,0,0,0,72,464a7.26,7.26,0,0,0,2.91-.6l56.21-22a15.7,15.7,0,0,1,12,.2c18.94,7.38,39.88,12,60.83,12A159.21,159.21,0,0,0,284,432.11" style="fill:none;stroke:#000;stroke-linecap:round;stroke-miterlimit:10;stroke-width:32px"></path>
</svg>

Should these be stripped as well, like you did in #18 ?

@marc2332 marc2332 added the bug Something isn't working label Oct 15, 2023
@marc2332 marc2332 self-assigned this Mar 26, 2024
@marc2332
Copy link
Member

hey! Sorry for taking that long, I am fixing this in #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants