Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscriptionManager class, bugfixes #106

Merged
merged 11 commits into from
Aug 3, 2021
Merged

SubscriptionManager class, bugfixes #106

merged 11 commits into from
Aug 3, 2021

Conversation

droserasprout
Copy link
Member

@droserasprout droserasprout commented Jul 26, 2021 •
edited
Loading

Improvements:

  • Class that holds state of TzKT SignalR subscriptions
  • Formatted logging of index messages

Bugfixes:

  • Fix displaying help messages on known errors
  • Fix missing ctx.logger in job handlers
  • Fix incorrect job scheduler configuration

@droserasprout
Copy link
Member Author

Tezos profiles indexer

@droserasprout
Copy link
Member Author

Help messages not printed

@droserasprout droserasprout changed the title Fix error messages, add subscribe_by_entrypoints config option SubscriptionManager, subscribe_by_entrypoints option, bugfixes Jul 30, 2021
@droserasprout
Copy link
Member Author

Logs: index name

@droserasprout droserasprout marked this pull request as ready for review August 2, 2021 09:53
m-kus
m-kus reviewed Aug 2, 2021
View reviewed changes
src/dipdup/config.py Outdated
@@ -545,6 +568,7 @@ class OperationIndexConfig(IndexConfig):
contracts: Optional[List[Union[str, ContractConfig]]] = None

stateless: bool = False
subscribe_by_entrypoints: bool = False
Copy link
Member

@m-kus m-kus Aug 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More generic approach:

subscribe: default | all | by_entrypoints | by_code (future) | other

or

event_filters:
  - contracts (default)
  - types (default)
  - entrypoints

that way we can combine default filters (types + address) with entrypoints

@droserasprout droserasprout changed the title SubscriptionManager, subscribe_by_entrypoints option, bugfixes SubscriptionManager class, bugfixes Aug 3, 2021
@droserasprout droserasprout merged commit 65b9ea3 into master Aug 3, 2021
@droserasprout droserasprout deleted the feat/entrypoints-subscription branch August 3, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kus m-kus m-kus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droserasprout @m-kus