Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Protect global endpoints #18

Closed
wellingguzman opened this issue Mar 27, 2018 · 7 comments
Closed

Protect global endpoints #18

wellingguzman opened this issue Mar 27, 2018 · 7 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@wellingguzman
Copy link
Contributor

We have two endpoints (/types and /server) that cannot be "protected" via ACL (Permissions).

Are these types of endpoints going to be admin-only, user-only or public?

@wellingguzman wellingguzman added the question Further information is requested label Mar 27, 2018
@benhaynes
Copy link
Member

And /install, right? I think these should be admin only (for the default env) or have a separate config? Not sure the best way to handle this... @rijkvanzanten ?

@rijkvanzanten rijkvanzanten changed the title Protect endpoints Protect globalendpoints Mar 27, 2018
@rijkvanzanten rijkvanzanten changed the title Protect globalendpoints Protect global endpoints Mar 27, 2018
@rijkvanzanten rijkvanzanten added the help wanted Extra attention is needed label Mar 27, 2018
@rijkvanzanten
Copy link
Member

(for the default env)

@benhaynes the environments don't come into play, since these are api global.

@rijkvanzanten
Copy link
Member

The options so far:

  1. Have them use the permissions system (ACL)
    This would basically mean all global endpoints are moving to use envs (/server/ping = /_/server/ping). This would mean we can use the "standard" auth flow and call it a day

  2. We have to come up with a new auth flow for just these endpoints..
    I have no idea how this would work at this point in time.

@benhaynes
Copy link
Member

I'd say let's go with option 1... we have enough to deal with, and I think that makes the most sense (since it uses something we already have).

@rijkvanzanten
Copy link
Member

Note: These endpoints should be accessible by all logged in users, not just admins.

@rijkvanzanten
Copy link
Member

/install can be blocked off to just admins though, but the others are being used by the app

@wellingguzman
Copy link
Contributor Author

We cannot block /install to admin, because we don't have admin before installation.

Like with /installation 6.x this is public endpoint that will be block after the first installation. (maybe after first installation will be admin-only, to install more environments?)

Having in inside environments (/_/) only make per environments but still we don't have a specific permission that we can check against, such as read or create.

Example, for item comments, how we can check if the user is allowed to comment on a item?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants