Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Change allowed_statuses to status_blacklist #226

Closed
rijkvanzanten opened this issue Jun 30, 2018 · 1 comment
Closed

Change allowed_statuses to status_blacklist #226

rijkvanzanten opened this issue Jun 30, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@rijkvanzanten
Copy link
Member

Is your feature request related to a problem? Please describe.
We treat the management of fields on a blacklist bases; eg: when adding a fieldname to the column, it disables the field. However, statuses work the other way around. Adding a status name to the column activates it. This also means that by default all the statuses are disabled.

Describe the solution you'd like
Instead of calling it allowed_statuses (and thus making it opt-in), name it status_blacklist (in line with read_field_blacklist and write_field_blacklist and make it opt-out.

Describe alternatives you've considered
The alternative would be to add all the fields on create of new rows, but this seems like an extra (unnecessary) hassle.

@benhaynes thoughts?

@rijkvanzanten rijkvanzanten added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jun 30, 2018
@benhaynes
Copy link
Member

Very good point, I agree. 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants