/webhooks/:id/:token/slack ignores wait query parameter

[vladfrangu]

Attempting to send a message through a webhook on the slack path ignores the wait parameter, and always returns "ok"

curl --request POST \
  --url https://canary.discordapp.com/api/webhooks/:id/:token/slack?wait=true \
  --header 'content-type: application/json' \
  --data '{
  "username": "Test123",
  "attachments": [{
    "pretext": "this looks pretty cool",
    "color": "#F0F",
    "footer": "This is a test",
    "ts": 1565708994
  }]
}'

Per the docs, waits for server confirmation of message send before response (defaults to true; when false a message that is not saved does not return an error)

[night]

wait defaults to true on the Slack endpoint to ensure compatibility with Slack integrations, so that's why you receive no virtual difference between a request with and without it.

[vladfrangu]

But shouldn't wait return the message object if true? It's inconsistent with the normal execute webhook endpoint

[Zoddo]

This endpoint is emulating slack. So it should return what a true slack webhook would return to be compatible with existing implementations. If it returns a Discord message object, some implementations may think the webhook failed (unexpected data)…

Anyway, this is consistent with the documentation. It doesn't say that slack/github endpoints should return the message object. Only the "normal" endpoint will return the object.