From 154b1d874e7b18bcedab52729e0fbc970d446d39 Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Fri, 11 Oct 2024 15:36:36 +0100 Subject: [PATCH] refactor: name approach --- packages/discord.js/src/managers/UserManager.js | 2 +- packages/discord.js/src/structures/User.js | 2 +- packages/discord.js/src/util/Util.js | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/discord.js/src/managers/UserManager.js b/packages/discord.js/src/managers/UserManager.js index 228cf12d1cf5..d8927a0b2638 100644 --- a/packages/discord.js/src/managers/UserManager.js +++ b/packages/discord.js/src/managers/UserManager.js @@ -105,7 +105,7 @@ class UserManager extends CachedManager { * Flags may still be retrieved via {@link UserManager#fetch}. */ async fetchFlags(user, options) { - emitDeprecationWarningForUserFetchFlags(true); + emitDeprecationWarningForUserFetchFlags(this.constructor.name); return (await this.fetch(user, options)).flags; } diff --git a/packages/discord.js/src/structures/User.js b/packages/discord.js/src/structures/User.js index c51a681a4697..6c984958983a 100644 --- a/packages/discord.js/src/structures/User.js +++ b/packages/discord.js/src/structures/User.js @@ -351,7 +351,7 @@ class User extends Base { * Flags may still be retrieved via {@link User#fetch}. */ fetchFlags(force = false) { - emitDeprecationWarningForUserFetchFlags(false); + emitDeprecationWarningForUserFetchFlags(this.constructor.name); return this.client.users.fetchFlags(this.id, { force }); } diff --git a/packages/discord.js/src/util/Util.js b/packages/discord.js/src/util/Util.js index b85b3d68a8f8..9a02719a63b3 100644 --- a/packages/discord.js/src/util/Util.js +++ b/packages/discord.js/src/util/Util.js @@ -504,12 +504,11 @@ function resolveSKUId(resolvable) { /** * Deprecation function for fetching user flags. - * @param {boolean} userManager Whether the class name is the user manager + * @param {string} name Name of the class * @private */ -function emitDeprecationWarningForUserFetchFlags(userManager) { +function emitDeprecationWarningForUserFetchFlags(name) { if (deprecationEmittedForUserFetchFlags) return; - const name = userManager ? 'UserManager' : 'User'; process.emitWarning(`${name}#fetchFlags() is deprecated. Use ${name}#fetch() instead.`); deprecationEmittedForUserFetchFlags = true; }