Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabling array contracts #21

Closed
mlippens opened this issue Apr 8, 2014 · 1 comment
Closed

Re-enabling array contracts #21

mlippens opened this issue Apr 8, 2014 · 1 comment

Comments

@mlippens
Copy link

mlippens commented Apr 8, 2014

Maybe it is worth into enabling array contracts again? I checked out harmony-reflect with your earlier non-working example at this issue and it seems to be fixed. After some experimenting this seems to be the most up-to-date implementation, since the example also doesn't work in gecko yet.

Furthermore, the author states that both Array.isArray() and [].concat are patched for array proxies.
@mlippens
Copy link
Author

mlippens commented Apr 8, 2014

Okay, so it seems array contracts got re-enabled somehow, but I can't find the commit stating it did. I'll try to enable the shim and see what that does for contracts.js.

@mlippens mlippens closed this as completed Apr 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlippens