Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimph 2.0 #140

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

nimph 2.0 #140

wants to merge 77 commits into from

Conversation

disruptek
Copy link
Owner

With Nimble now supporting localdeps, we no longer need to support Nimble. 😉

This lets us remove most/all callouts to subprocesses, parsing of the packages.json, and ideally, parsing of NimScript. We might embed the compiler for interpreting it, but we won't call out to dump project metadata anymore.

I've learned some things in the last year, so this will be a 2.0 rewrite with breaking API changes. Most of the changes are caused by even tighter "correct by construction" types.

From the perspective of UX, the early changes will be as follows:

  • we'll try to work with Nimble, but the stance will be Nimph-first from now on
  • we'll use Git submodules for dependencies and intuitive relative import paths
  • we'll generate your nim.cfg and probably the project.nimble as well
  • we'll use hashes in lockfiles, because now there's no reason not to 😁
  • we'll bundle Nimph in https://gitnim.com/ for easy binary distribution; no more build bs
  • we'll expose a cache via frosty and a dependency graph via gram for tools

The idea with this last bit is that Nimph can provide an API for tools that won't require the full dynamic library support of SSH, libgit2, and crypto. We'll be able to do simple stuff like change to the directory of dependency foo or dump the dependency tree as a PNG in tiny extensions without having the (relatively complex) Nimph development environment on the user's host.

Future goals of a 2.0 branch will be to provide some kind of TUI for easily upgrading dependencies and/or inspecting the test matrix. I'd like to see CI integration here, probably GitHub only, to start.

Notable technology coming down the pike which we'll be able to leverage includes shallow repositories (from libgit) and a GraphQL library for Nim that we can use for GitHub Actions.

This PR is not ready for consumption; in fact, @Clyybber, if you try to compile it Nim will infinite loop. :laugh:

@disruptek disruptek added this to the remove Nimble dependency milestone Aug 23, 2020
This was linked to issues Aug 23, 2020
teach projects that they have an arbitrary number of urls #21
Open
recommend tagging when requirements change #54
Open
should do something useful with git submodules #63
Open
switch to concepts for groups #87
Open
confused by multiple disparate version tags on the same commit #90
Open
support tag comparisons, eg. "foo >= #MyNiceRelease" #97
Open
handle a broken .nimble file as gracefully as possible #98
Open
support arbitrary git repositories #122
Closed
Record the revision of a reference upon locking. Optionally also a hash over the contents. #138
Open
choose to support choosenim at runtime #139
Open
@disruptek disruptek removed a link to an issue Aug 23, 2020
support arbitrary git repositories #122
Closed
@disruptek disruptek linked an issue Aug 23, 2020 that may be closed by this pull request
run nimscript ourselves instead of calling nimble #24
Open
@disruptek
Copy link
Owner Author

Check out this concept insanity from running the recent groups.nim (you need to use cpp):

http://ix.io/2v3M

🔵  we start with a simple "collection".
⚫ var g: seq[string]
🔵 add some values.
🟢 g.add "Goats"
🟢 g.add "pigs"
🔵 make an immutable copy.
⚫ let h = g
🔵 a string is a suitable type for tests.
🟢 assert string is Suitable
🔵 g is a Collectable of strings.
🟢 assert g is Collectable[string]
🔵 sure, fine, as expected.
🟢 assert g is Collectable
🔵 ok, great.  and this works, for now!
🟢 assert g is Groupable[string]
🔵 this does not -- but why not?
🔴 assert g is Groupable
🔴  🗏 207  assert g is Groupable
🔴 🗇 groups.nim
🔴 🗇   207     assert g is Groupable  # in groups()
🔴 🗇 ../../../nims/lib/system/assertions.nim
🔴 🗇    30   cast[Hide](raiseAssert)(msg)  # in failedAssertImpl()
🔴 🗇    23   sysFatal(AssertionDefect, msg)  # in raiseAssert()
🔴 🗇 ../../../nims/lib/system/fatal.nim
🔴 🗇    49     raise (ref exceptn)(msg: message)  # in sysFatal()
🔵 h is immutable, so isn't Groupable[string], right?
🔴 assert h isnot Groupable[string]
🔴  🗏 209  assert h isnot Groupable[string]
🔴 🗇 groups.nim
🔴 🗇   209     assert h isnot Groupable[string]  # in groups()
🔴 🗇 ../../../nims/lib/system/assertions.nim
🔴 🗇    30   cast[Hide](raiseAssert)(msg)  # in failedAssertImpl()
🔴 🗇    23   sysFatal(AssertionDefect, msg)  # in raiseAssert()
🔴 🗇 ../../../nims/lib/system/fatal.nim
🔴 🗇    49     raise (ref exceptn)(msg: message)  # in sysFatal()
🔵 if you add `del(w, T)` to the Groupable,
🔵 then g is no longer a Groupable[string]!
🟢 assert g is Groupable[string]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
remove Nimble dependency
1 participant
@disruptek