Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with pending Nix changes #77

Open
nrdxp opened this issue Jun 3, 2022 · 9 comments
Open

incompatible with pending Nix changes #77

nrdxp opened this issue Jun 3, 2022 · 9 comments
Labels
🔥 Priority: High This issue is prioritized as high 💪 Effort: 5 This issue is of high complexity or just not yet well understood 🔧 Type: Maintenance This issue targets general maintenance
Milestone

Comments

@nrdxp
Copy link
Contributor

nrdxp commented Jun 3, 2022

Running with NixOS/nix#6530, which is currently planned for the next point release, I am getting the following eval error pretty much everywhere in a work project:

error: evaluation aborted with the following error message: '

       Everything under ${cellsFrom}/* is considered a Cell

       Cells are directories by convention and therefore
       only directories are allowed at ${cellsFrom}/*

       Please remove '${cellsFrom}/std' and don't forget to add the change to version control.
       '

Not sure the root cause yet. Will post back when I know more

@nrdxp
Copy link
Contributor Author

nrdxp commented Jun 4, 2022

okay, so with the follow diff:

diff --git a/src/grow.nix b/src/grow.nix
index 1116a3b..a4a5726 100644
--- a/src/grow.nix
+++ b/src/grow.nix
@@ -86,7 +86,7 @@
     # Validations ...
     Organelles = validate.Organelles organelles;
     Systems = validate.Systems systems;
-    Cells = l.mapAttrsToList (validate.Cell cellsFrom Organelles) (l.readDir cellsFrom);
+    Cells = l.mapAttrsToList (validate.Cell cellsFrom Organelles) (l.traceVal (l.readDir cellsFrom));
 
     # Helpers ...
     accumulate =

It seems the type of cells/std is no longer known at this stage:

trace: { std = "unknown"; }

Probably because of the new virtual filesystem. I would imagine an unknown value in a builtin function is undesirable and should be worked out before the change is merged, so maybe it won't affect us by that time?

@blaggacao
Copy link
Collaborator

blaggacao commented Sep 7, 2022

@nrdxp Is this issue still warranted or should we revive mitigation efforts in any way?

@nrdxp nrdxp changed the title incompatible with pending Nix 2.10 changes incompatible with pending Nix changes Sep 7, 2022
@nrdxp
Copy link
Contributor Author

nrdxp commented Sep 7, 2022

Well the lazy-trees branch still hasn't been merged: NixOS/nix#6530

I guess we'll have to wait and see what this looks like after it is merged, as it is a pretty fast moving target.

@blaggacao
Copy link
Collaborator

  • Is this still true?

  • What can we do ahead of time?

@nrdxp
Copy link
Contributor Author

nrdxp commented Dec 19, 2022

  • Last I checked yes. The lazy-trees branch seems to break a lot of flakes for me, to the point I haven't been able to test it much
  • We can try to work out the breakage, but the lazy-tree branch still has changes coming in, so perhaps we should wait til it is at least out of draft

@blaggacao
Copy link
Collaborator

changes coming in

changes yes, but maybe not breakages, any more? I'd like the idea to start thinking in forward-compatibility, here.

@nrdxp
Copy link
Contributor Author

nrdxp commented Dec 19, 2022

Yeah but as I said, it breaks a lot of stuff so it's kinda hard to test and pretty intimidating to start to fix. Feel free anytime though 😅

@nrdxp
Copy link
Contributor Author

nrdxp commented Dec 20, 2022

Looks like the lazy-trees branch is finally out of draft, so it may be just the time to give it another shot.

@settings settings bot removed the help wanted label Dec 22, 2022
@blaggacao blaggacao added this to the Release v1 milestone Dec 22, 2022
@blaggacao blaggacao added 🔧 Type: Maintenance This issue targets general maintenance 🔥 Priority: High This issue is prioritized as high 💪 Effort: 5 This issue is of high complexity or just not yet well understood labels Dec 22, 2022
@blaggacao
Copy link
Collaborator

These nix changes are pending and pending ⌛ 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Priority: High This issue is prioritized as high 💪 Effort: 5 This issue is of high complexity or just not yet well understood 🔧 Type: Maintenance This issue targets general maintenance
Projects
None yet
Development

No branches or pull requests

2 participants