Implement vdaf::Collector on dummy VDAF
#948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy VDAF implementation on `prio::vdaf::dummy::Vdaf` was lacking an implementation of `prio::vdaf::Collector`. Additionally, we defined its `AggregateResult` associated type as `u8`, which is awkward at best since the `AggregateShare` associated type is a tuple struct around `u64`. We change `prio::vdaf::dummy::Vdaf::AggregateResult` to be `u64`. This breaking change to public API is deemed acceptable since this is gated behind `test-util`.
1 task
divergentdave
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dummy VDAF implementation on
prio::vdaf::dummy::Vdafwas lacking an implementation ofprio::vdaf::Collector. Additionally, we defined itsAggregateResultassociated type asu8, which is awkward at best since theAggregateShareassociated type is a tuple struct aroundu64. We changeprio::vdaf::dummy::Vdaf::AggregateResultto beu64. This breaking change to public API is deemed acceptable since this is gated behindtest-util.