Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<codecvt> is deprecated – optionally allow using ICU? #26

Open
TinoDidriksen opened this issue Apr 3, 2019 · 2 comments
Open

<codecvt> is deprecated – optionally allow using ICU? #26

TinoDidriksen opened this issue Apr 3, 2019 · 2 comments

Comments

@TinoDidriksen
Copy link
Contributor

Header and the related functions are deprecated as of C+17 - https://en.cppreference.com/w/cpp/header/codecvt

It is used in at least two places in the code ( https://github.com/divvun/libdivvun/search?q=codecvt ).

@unhammer
Copy link
Member

unhammer commented Apr 3, 2019

Deprecated without a replacement, even :-(

It's used in getCasing and toupper / tolower in order to convert utf-8 strings to wstrings so we can call isupper/islower/towupper on non-latin1 stuff. As suggest.hpp says,

// #ifndef icu TODO

@unhammer unhammer changed the title <codecvt> is deprecated <codecvt> is deprecated – optionally allow using ICU? Apr 17, 2019
@unhammer
Copy link
Member

unhammer commented Apr 17, 2019

Since making a native locale fails in LO on mac (even though it shouldn't?) we may have a functionality-reason to start using ICU too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants