Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python.h check is wrong for Python 3.8 #39

Closed
TinoDidriksen opened this issue Feb 26, 2020 · 0 comments
Closed

Python.h check is wrong for Python 3.8 #39

TinoDidriksen opened this issue Feb 26, 2020 · 0 comments

Comments

@TinoDidriksen
Copy link
Contributor

https://github.com/divvun/libdivvun/blob/master/configure.ac#L152 checks for ${python_include_path}/Python.h which results in a conftest.cpp that does #include <python3.8/Python.h> - this is not the correct way to check whether Python.h is usable, and never has been. It has worked so far, but Python 3.8 breaks that.

The test must instead add the result of python3-config --includes to the build flags and only #include <Python.h>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant