Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Append for Cow<'a, str> #481

Closed
Flying-Toast opened this issue Sep 8, 2024 · 1 comment · Fixed by #482
Closed

Implement Append for Cow<'a, str> #481

Flying-Toast opened this issue Sep 8, 2024 · 1 comment · Fixed by #482
Labels
good first issue

Comments

@Flying-Toast
Copy link
Contributor

Both &'a str and String implement Append, but Cow<'a, str> doesn't implement it. Could it be added? It would enable to me avoid an allocation for my use case.
@diwic
Copy link
Owner

diwic commented Sep 8, 2024

Sure, go ahead and submit a PR!

@Flying-Toast Flying-Toast mentioned this issue Sep 8, 2024
Merged
@diwic diwic closed this as completed in #482 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement Append for Cow<'a, str> and Cow<'a, [T]>
2 participants
@diwic @Flying-Toast