Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed kerberos auth handler #267

Closed
nitzmahone opened this issue Jul 8, 2019 · 5 comments · Fixed by #268
Closed

Embed kerberos auth handler #267

nitzmahone opened this issue Jul 8, 2019 · 5 comments · Fixed by #268

Comments

@nitzmahone
Copy link
Collaborator

nitzmahone commented Jul 8, 2019

The requests-kerberos auth handler pywinrm relies on for Kerberos auth is going to remove functionality needed by pywinrm for HTTP message encryption (see requests/requests-kerberos#133) in order to fix some concurrency issues when using requests-kerberos from multiple threads with a shared session object.

Rather than scrambling to adapt pywinrm to the (still unproven) method being proposed over on requests-kerberos, I'm suggesting that we embed a copy of requests-kerberos locally. We could also either just switch over to requests-gssapi or embed a copy of that and use python-gssapi directly, but we'd have to keep some form of the old stuff around to support Windows clients anyway (since python-gssapi didn't support Windows last I checked).

@badcure @jborean93 this is a fairly major storm headed our way, so we'll need to act quickly before requests-kerberos does a release, or everyone's going to be broken... Thoughts?

@badcure
Copy link
Collaborator

badcure commented Jul 9, 2019

👍 to a copy of requests-kerberos. I think that would be the path with the least moving parts, since this changes is coming soon. Reading up on the issue now(i.e. wrapping my head around it).

@jborean93
Copy link
Collaborator

I'm good for having a copy, ultimately it would be nice to move away from pykerberos/winkerberos to python-gssapi and pywin32 but that would be a change further down the track when we aren't pressed for time.

@nitzmahone
Copy link
Collaborator Author

OK cool- I'll try to whip up a PR today that embeds it and updates the kerberos extras_require section to do the right thing. Thanks for the feedback.

@frozencemetery
Copy link

When you say "support Windows", do you mean: supports Windows using the SSPI, or supports Windows users who install MIT Kerberos for Windows? (We're in the process of merging the second one: pythongssapi/python-gssapi#177 )

@jborean93
Copy link
Collaborator

@frozencrmetary, would be the former using SSPI. Currently requests-kerberos works over Linux and Windows which we need to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants