Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom volumes don't work for server #9

Closed
shk3bq4d opened this issue Mar 2, 2021 · 1 comment · Fixed by #10
Closed

custom volumes don't work for server #9

shk3bq4d opened this issue Mar 2, 2021 · 1 comment · Fixed by #10
Labels
bug Something isn't working.

Comments

@shk3bq4d
Copy link

shk3bq4d commented Mar 2, 2021

Hello,

nice project! I hope you keep on the good work in there!

I believe that the custom volume code in the server template is incomplete, namely the integration of:

.Values.server.volumes
.Values.server.volumeMounts

I'll create a pull request.

Best regards!
@shk3bq4d shk3bq4d mentioned this issue Mar 2, 2021
Merged
@dj-wasabi dj-wasabi added the bug Something isn't working. label Mar 2, 2021
@dj-wasabi
Copy link
Owner

Hi @shk3bq4d

Thank you! Yes, it needs some more work. But currently a bit to much going right now. So hopefully soon I will be able to fully continue with this.

In the mean time, if you need a fix/functionality you can always create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix custom volumes for zabbix-server shk3bq4d/helm-zabbix
2 participants
@dj-wasabi @shk3bq4d