URL name "filer_file_fileicon" defined twice

[stefan6419846]

We are employing a check for duplicate URL names in our applications and stumbled upon an issue when using django-filer: It seems like filer_file_fileicon is being defined/configured twice.

If I could pinpoint this correctly, the issue is about filer.admin.fileadmin.FileAdmin.get_urls defining the URL name filer_file_fileicon. filer.admin.imageadmin.ImageAdmin extends this class, but does not override get_urls, thus the duplicate is being generated.

django-filer/filer/admin/fileadmin.py

Lines 166 to 171 in dbeda3a

	def get_urls(self):
	return super().get_urls() + [
	path("icon/<int:file_id>/<int:size>",
	self.admin_site.admin_view(self.icon_view),
	name="filer_file_fileicon")
	]

django-filer/filer/admin/imageadmin.py

Lines 92 to 94 in dbeda3a

	class ImageAdmin(FileAdmin):
	change_form_template = 'admin/filer/image/change_form.html'
	form = ImageAdminForm

I have been able to verify that using

class ImageAdmin(FileAdmin):
    change_form_template = 'admin/filer/image/change_form.html'
    form = ImageAdminForm

    def get_urls(self):
        result = super().get_urls()
        result = [x for x in result if x.name != 'filer_file_fileicon']
        return result

does indeed fix this specific issue, although I have not yet tested whether this might have other side effects.

[fsbraun]

@stefan6419846 Thanks for pointing this out! I think the issue is here in line 170:

django-filer/filer/admin/fileadmin.py

Lines 166 to 171 in dbeda3a

	def get_urls(self):
	return super().get_urls() + [
	path("icon/<int:file_id>/<int:size>",
	self.admin_site.admin_view(self.icon_view),
	name="filer_file_fileicon")
	]

The name should have the model name in lower case in the middle.