Svg image stored as File object make folder list crash

[fabien-michel]

I don't know how it happened, but 4 years ago an svg file was uploaded using filer and it was stored in database as a File and not an Image object. (still has `'image/svg+xml' mime though)

Since "recent" modifications of filer, this situation make filer crash when trying to list the folder with this file.

It crash here

django-filer/filer/models/filemodels.py

Line 361 in 58b017d

return self.get_admin_url("expand")

because the expand admin url, does not exists in FileAdmin here:

django-filer/filer/admin/fileadmin.py

Line 202 in 58b017d

def get_urls(self):

Because the URL exists in ImageAdmin, and in normal scenario a SVG file is stored as an Image, it doesn't fail.

[fabien-michel]

I've found 6 files of 585 which are SVG but stored as File

[jrief]

does this happen with all SVG files or only specific ones?

[0911R00]

Just uploaded a svg-file with django-filer (3.1.3) in django-cms (4.1.4). On redirect after the upload to http://127.0.0.1:8000/de/admin/filer/folder/1/list/ an error appears:

Reverse for 'filer_image_expand_view' not found. 'filer_image_expand_view' is not a valid view function or pattern name.

Error during template rendering

In template (...)\venv\Lib\site-packages\filer\templates\admin\filer\folder\directory_table_list.html, error at line 142

<a href="{% if 'svg' in file.mime_type %}{% url 'admin:filer_image_expand_view' file.pk %}{% else %}{{ file.canonical_url }}{% endif %}" ...

Searching for filer_image_expand_view in django-filer had no other occurences.

I made a quick and dirty dummy-test and everything worked as it should:

<a href="{% if 'svg' in file.mime_type %}{{ file.canonical_url }}{% else %}{{ file.canonical_url }}{% endif %}" ...

[fsbraun]

@0911R00 I believe this has been fixed in #1471 which was released in version 3.1.4 What version are you using? Can you upgrade?

[fsbraun]

@fabien-michel Yes, I can see that miscategorised files are a problem. A solution might be to catch errors here:

django-filer/filer/models/filemodels.py

Lines 347 to 355 in 58b017d

	def get_admin_url(self, action):
	return reverse(
	'admin:{}_{}_{}'.format(
	self._meta.app_label,
	self._meta.model_name,
	action
	),
	args=(self.pk,)
	)

Putting that in a try-except block would avoid the crash. Additionaly, the buttons without liks should be disabled.

Can I encourage you to create a PR?

[0911R00]

@0911R00 I believe this has been fixed in #1471 which was released in version 3.1.4 What version are you using? Can you upgrade?

Thanks! Works perfectly!