Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button layout/sizes with Django 4.2 and CMS 3.11 #506

Closed
petrklus opened this issue Jan 10, 2024 · 4 comments · Fixed by #507
Closed

Button layout/sizes with Django 4.2 and CMS 3.11 #506

petrklus opened this issue Jan 10, 2024 · 4 comments · Fixed by #507

Comments

@petrklus
Copy link

petrklus commented Jan 10, 2024

Upgraded a project to Django 4.2 and noticed odd action button layouts with djangocms-admin-style==3.2.7 and django-cms==3.11.4:

image

Also, the layout of the admin navbar is a bit odd:

image

For custom models, the actions row looks better but the buttons are still not aligned size-wise (the delete button is shorter than the others):

image

@fsbraun is the above expected with Django 4.2?

@petrklus petrklus changed the title Button layout with Django 4.2 and CMS 3.11 Button layout/sizes with Django 4.2 and CMS 3.11 Jan 10, 2024
@fsbraun
Copy link
Member

fsbraun commented Jan 10, 2024

@petrklus Thanks for pointing out these inconsistencies!

Can you check if pip install git+https://github.com/fsbraun/djangocms-admin-style@fix/django-4-2-submit-row will solve your problem? Please let me know if there are other inconsistencies you notice!

@petrklus
Copy link
Author

thank you for the quick response @fsbraun , will review your fix and also have a general poke around to see if anything else needs amending

@petrklus
Copy link
Author

that fixed the issue @fsbraun - will now continue and review if I can spot any further issues, thank you for the fix!

@fsbraun
Copy link
Member

fsbraun commented Jan 13, 2024

@petrklus Any new observations? If not, I will go to release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants