Publishing a .net 6.0 specific version of the package (this should al… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so disable recycling collectors by default)
|
WHY? This is something that broke our production. We had fixed CPU leak, and now it is back. Shouldn't preprocessor directives be changed to NET5_0_OR_GREATER in this PR? |
|
What's more, it is disabling RecycleCollectorsEvery on net 6 and above - so you don't have the possibility to configure it back. :( |
|
I created a PR with NET5_0_OR_GREATER - this would bring back the recycling when using target net6 and above. |
|
@darthkurak @starkpl I've just merged and pushed v4.4.0 which restores the ability to optionally enable recycling under .NET 6.0 (it defaults to being off). Have a look and let me know if it helps or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so disable recycling collectors by default)