Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private registry authentication #10

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

ledermann
Copy link
Contributor

@ledermann ledermann commented Mar 23, 2018

This PR includes a change by @pdeveltere and a README enhancement by me. It allows using shepherd for private registries.

Tested with Docker 18.03.0-ce. Closes #6

@matteocng
Copy link

Thanks for this. Successfully tested on Swarm - Docker version 18.03.0-ce, build 0520e24, compose-file version 3.6.

Copy link
Collaborator

@djmaze djmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

(Sorry for the late reaction.)

shepherd Outdated
echo "Sleeping $sleep_time before next update"
sleep "$sleep_time"
done


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these empty lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@djmaze
Copy link
Collaborator

djmaze commented Apr 9, 2018

Thanks for the contribution!

@djmaze djmaze merged commit 781b554 into containrrr:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with private registry on 17.06
3 participants