Filtering services #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response. This looks cool, thanks! Merging. |
|
This is so cool!! |
mduheaume
added a commit
to mduheaume/shepherd
that referenced
this pull request
May 16, 2019
Merge pull request containrrr#24 from mduheaume/filter-services
|
does the filter_services label on the to-update container needs to set to true? or just has to be there < label no matter what value is in it? |
|
@bd8392 There is no filter_services label. The container just needs a label as specified. In the example shown above, it could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow for filtering the list of services to update using a
FILTER_SERVICESenv var. It should work with any value you can give to the--filteroption indocker service ls. For example, if you only want to update services with anautodeploylabel, setFILTER_SERVICES="label=autodeploy". This might resolve #9.