Add support for rolling back on a failed update #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker service update` will exit with `1` and write something like `service update paused: update paused due to failure or early termination of task ...` to stderr if the updated service fails to start or remains unhealthy. With this change this event appears in the logs explicitly.
By setting the `ROLLBACK_ON_FAILURE` variable if an update fails Shepherd will roll it back to the previous version, thus avoiding a service failure as a result of the update. If the Apprise Sidecar is set it will also send a notification about this.
|
@andrasmaroy Very cool and useful addition, thanks! Just added one more line in order to skip the success notification after rollback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker service updatewill exit with1and write something likeservice update paused: update paused due to failure or early termination of task ...to stderr if the updated service fails to start or remains unhealthy.By setting the
ROLLBACK_ON_FAILUREvariable if an update fails Shepherd will roll it1 back to the previous version, thus avoiding a service failure as a result of the update. If the Apprise Sidecar is set it will also send a notification about this.