From 657db52b093296e232c015357572efe3c9cab25a Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Thu, 15 Dec 2022 02:52:46 +0000 Subject: [PATCH] [BREAKING] remove diff display from 'task undo' TaskChampion does not make the necessary information available to accomplish this, but see #2928. --- src/TDB2.cpp | 3 +-- test/undo.t | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/TDB2.cpp b/src/TDB2.cpp index ffee3fc81..cbb3faf1d 100644 --- a/src/TDB2.cpp +++ b/src/TDB2.cpp @@ -780,8 +780,7 @@ void TDB2::revert () std::string prior; revert_undo (u, uuid, when, current, prior); - // Display diff and confirm. - show_diff (current, prior, when); + // Confirm. if (! Context::getContext ().config.getBoolean ("confirmation") || confirm ("The undo command is not reversible. Are you sure you want to revert to the previous state?")) { diff --git a/test/undo.t b/test/undo.t index e23658739..baed6cfc3 100755 --- a/test/undo.t +++ b/test/undo.t @@ -74,6 +74,7 @@ class TestUndoStyle(TestCase): self.t("add one project:foo priority:H") self.t("1 modify +tag project:bar priority:") + @unittest.expectedFailure # undo diffs are not supported def test_undo_side_style(self): """Test that 'rc.undo.style:side' generates the right output""" self.t.config("undo.style", "side") @@ -81,6 +82,7 @@ class TestUndoStyle(TestCase): self.assertNotRegex(out, "-tags:\s*\n\+tags:\s+tag") self.assertRegex(out, "tags\s+tag\s*") + @unittest.expectedFailure # undo diffs are not supported def test_undo_diff_style(self): """Test that 'rc.undo.style:diff' generates the right output""" self.t.config("undo.style", "diff")