Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add sbt-spiewak projects to the Scala 3 community build #83

Closed
armanbilge opened this issue Dec 10, 2021 · 2 comments
Closed

Can't add sbt-spiewak projects to the Scala 3 community build #83

armanbilge opened this issue Dec 10, 2021 · 2 comments

Comments

@armanbilge
Copy link
Contributor

This is because the isDotty setting added to sbt-spiewak in #54 conflicts with the one in the DottyPlugin used in the community build:

/__w/dotty/dotty/community-build/community-projects/http4s/build.sbt:1059: error: reference to isDotty is ambiguous;
it is imported twice in the same scope by
import _root_.sbtspiewak.SpiewakPlugin.autoImport._
and import _root_.dotty.tools.sbtplugin.DottyPlugin.autoImport._
    if (isDotty.value && githubIsWorkflowBuild.value)

Currently, all the projects in the CB using sbt-spiewak are using an old version of the plugin. But this means they cannot be updated.

I've asked in scala/scala3#14071 (comment) if the DottyPlugin is still needed since it was merged into sbt. However, is the isDotty setting still necessary for sbt-spiewak? According to sbt/sbt#6080 isDotty has been renamed to isScala3 in sbt.

@armanbilge
Copy link
Contributor Author

Hmm, seems isScala3 didn't make it into sbt after all based on sbt/sbt#6080 (comment). So maybe we can rename isDotty in sbt-spiewak to isScala3.

@armanbilge
Copy link
Contributor Author

They are removing sbt-dotty from the Community Build in scala/scala3#14395.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant