Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change #== dependency from #coerce to #equalizer_coerce #28

Open
backus opened this issue Jun 10, 2016 · 0 comments
Open

Change #== dependency from #coerce to #equalizer_coerce #28

backus opened this issue Jun 10, 2016 · 0 comments

Comments

@backus
Copy link

backus commented Jun 10, 2016

I have an object which defines a #coerce instance method as part of its public API. I didn't realize until recently that this breaks #== for this object and all of the objects that own it until today.

I understand after talking to @dkubb that this is a weak convention in ruby, but it might make sense to deprecate the use of #coerce and instead depend on a method that is less likely to naturally collide with unrelated method names that are not meant for equalizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant