Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scanner flag #56

Merged
merged 1 commit into from
Jul 31, 2016
Merged

Added scanner flag #56

merged 1 commit into from
Jul 31, 2016

Conversation

dlazaro66
Copy link
Owner

No description provided.

// Notify QR not found
if (mOnQRCodeReadListener != null) {
mOnQRCodeReadListener.QRCodeNotFoundOnCamImage();
if (qrDecodingEnabled.get()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This method gets executed in Main Thread so you don't need it to be AtomicBoolean
  2. It's more readable if you do:
@Override public void onPreviewFrame(byte[] data, Camera camera) {
   if (!qrDecodingEnabled) {
      return;
   }

   // do something
}

@saguinav saguinav force-pushed the add_scanner_enable_function branch from bb78303 to 0cd7a0e Compare July 31, 2016 08:40
@dlazaro66 dlazaro66 merged commit 7595857 into master Jul 31, 2016
@saguinav saguinav deleted the add_scanner_enable_function branch July 31, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants