Added Possibility to choose the cameraId to be opened for decoding #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,8 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile 'com.dlazaro66.qrcodereaderview:qrcodereaderview:2.0.0' | |||
| //compile 'com.dlazaro66.qrcodereaderview:qrcodereaderview:2.0.0' | |||
| compile project (":qrcodereaderview") | |||
There was a problem hiding this comment.
I'm finally setting this to link the local project instead of the remote maven repository
There was a problem hiding this comment.
I don't think this is the right way to go. The sample project goal is to show how the library should be used. Using a compile project dependency is not something that library consumers will be able to do. Also using the real binary that is being deployed to maven will protect the sample project from unexpected errors.
…t knowing the cameraId
| @@ -54,6 +53,9 @@ | |||
| void onQRCodeRead(String text, PointF[] points); | |||
| } | |||
|
|
|||
| private static int CAMERA_FACING_BACK = Camera.CameraInfo.CAMERA_FACING_BACK; | |||
… example replacing the local project dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.