Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass Breaking Change to Source Maps #190

Closed
MethodGrab opened this issue Feb 9, 2015 · 7 comments
Closed

node-sass Breaking Change to Source Maps #190

MethodGrab opened this issue Feb 9, 2015 · 7 comments

Comments

@MethodGrab
Copy link
Contributor

gulp-sass errors when used with the current master branch of node-sass because the sourceMap output type has changed from an object to a string (sass/node-sass#583).

I know it's the master branch so compatibility isn't expected, this is just a heads up!

The error is:

~/dev/test/node_modules/gulp-sass/index.js:50
        obj.map.sources = obj.map.sources.map(function(source) {
                                         ^
TypeError: Cannot read property 'map' of undefined
    at opts.success (~/dev/test/node_modules/gulp-sass/index.js:50:42)
    at options.success (~/dev/libs/node-sass/lib/index.js:167:7)
@zzjin
Copy link

zzjin commented Feb 12, 2015

same error here and see that node-sass just released 2.0.1 with node 0.12.0 && iojs 1.2 support

@dawidk92
Copy link

+1

@dlmanning
Copy link
Owner

Am aware, am working on it. Everybody just stay calm.

@kylescousin
Copy link

Node-sass 2.0.1 yey,
zen - waiting for dlmanning's update

@mcshaman
Copy link

@dlmanning It is appreciated. :)

@dlmanning
Copy link
Owner

Fixed in 314ce5c

@MethodGrab
Copy link
Contributor Author

Thanks! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants