Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React and React-Dom should be added to dev and peer dependencies #13

Open
hjrdave opened this issue May 7, 2020 · 0 comments
Open

React and React-Dom should be added to dev and peer dependencies #13

hjrdave opened this issue May 7, 2020 · 0 comments

Comments

@hjrdave
Copy link

hjrdave commented May 7, 2020

I am using this library as a dependency for a private npm package I am developing. I noticed I was having an issue developing my package locally because a dependency kept installing React when I did an npm install. This caused conflicts between my developer environment and local package. A symlink is usually used for both local projects to prevent this conflict. Upon further research I discovered 'react-spinners-kit' has react and react-dom in the dependencies which is causing it to automatically install. I believe best practice is to have it in peer dependencies and not dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant