Skip to content
This repository has been archived by the owner on Feb 1, 2020. It is now read-only.

[WIP] Infer Storage Type pass for sparse tensors #110

Merged
merged 8 commits into from
Apr 21, 2017

Conversation

eric-haibin-lin
Copy link
Member

Please don't merge this in.

@piiswrong
Copy link
Member

@tqchen Would storage type be a better name?

@eric-haibin-lin
Copy link
Member Author

I prefer using storage type to chunk type.

@tqchen
Copy link
Member

tqchen commented Apr 12, 2017

storage type sounds good

@eric-haibin-lin eric-haibin-lin changed the base branch from master to sparse April 18, 2017 18:49
@eric-haibin-lin
Copy link
Member Author

TODO: disable mem sharing locally instead of globally.
Merge in a separate sparse branch for now.

@eric-haibin-lin eric-haibin-lin changed the title [WIP] Infer Chunk Type pass for sparse tensors [WIP] Infer Storage Type pass for sparse tensors Apr 18, 2017
@eric-haibin-lin
Copy link
Member Author

@piiswrong Added kDynamicStorage

ping @reminisce for awareness

@piiswrong piiswrong merged commit 319a8dd into dmlc:sparse Apr 21, 2017
eric-haibin-lin added a commit to eric-haibin-lin/nnvm that referenced this pull request Jun 7, 2017
* Add inferchunk pass

* Fix default type for infet chunk

* Add test for default chunk type

* disable mem sharing for sparse storage. global name replacement

* check dispatch_storage_type attr before retrieve it

* fix typo

* Add doc

* Add kDynamic Storage
piiswrong pushed a commit that referenced this pull request Jun 7, 2017
* [WIP] Infer Storage Type pass for sparse tensors (#110)

* Add inferchunk pass

* Fix default type for infet chunk

* Add test for default chunk type

* disable mem sharing for sparse storage. global name replacement

* check dispatch_storage_type attr before retrieve it

* fix typo

* Add doc

* Add kDynamic Storage

* force infer storage on backward pass (#1) (#113)

* force infer storage on backward pass (#1)

* force infer storage type for backward pass

* change none value for storage type to 0(kUndefinedStorage)

* Modify default value for storage type

* update unit test for infer storage

* fix windows compilation error (#115)

* remove unused logging
abergeron pushed a commit to abergeron/nnvm that referenced this pull request May 31, 2018
dmlc#110)

* [CODEGEN/PASS] Improve callpacked lowering, allow pass array callback.

* fix cython
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants