-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQ: Ability to set percentage match cutoff and/or keyword blacklist such as "live" or whitelist "official" in title. #12
Comments
the code uses lechentein distance to match names and titles, with a match ratio greater than 0.8.
Unfortunately this is never going to be perfect, increasing the match ratio can possibly get you better results. But consider the following: if i record 2 songs.
If i then upload both of them to youtube with the same name: dave - the great title Which 1 is correct based off the name? the problem here is user input is always at fault. If you have some way of making better determination, i can certainly implement it for you :) |
The problem is I'm getting alot of matches where it IS the artist singing the song but it's at some club where you can barely hear them and a bunch of people are talking over them....I'm then having to go delete that particular track....if I ever run ydl again it's going to grab the same track presumably...I'd rather set the ratio to .9 minimum and/or ignore tracks with "live" in the title. I don't see why allowing user set conditions would be a problem? Perhaps via environment variables. |
ill take a look today at adding some flexibility around matching. the code actually does the following already
ill add the option to increase the 0.8. |
One solution is to use a service like audiotag.info (based on a database of audio spectrograms) to attempt to identify some extracts from the downloaded YouTube video. Perhaps you could have multiple samples extracted from the same song, say, at the start, middle, and ending and based on some rules, ie: if all samples could be matched then it is highly likely to be a YouTube video with just the song itself and not someone's karaoke party. I see audiotag.info has an API, or maybe there are better alternatives, but it should be possible to narrow down the quality of a downloaded YouTube song a little better than matching just metadata which is what Lidarr itself seems to be doing. |
Could definitely look into such a solution :) |
Originally I just wanted a method to override the allowed percentage
required to a HIGHER amount for example if 85% was ok I was only going to
accept 95 and up to avoid recordings from concerts with people talking
ending up in my music library.
…On Mon, Mar 4, 2024 at 12:31 PM Dave ***@***.***> wrote:
Could definitely look into such a solution :)
PR's are also welcome.
I'm working on a number of things currently.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCY74GIVBBGOQ7ZLDP2A23YWSVYPAVCNFSM6AAAAAAYFQO372VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGEYTCMJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've gotten some bad matches on songs...typically someone recording the singer as a live concert. I'd like to have it only accept high percentage matches or whitelist things like the word "Official" or blacklist the word "Live" in the title.
The text was updated successfully, but these errors were encountered: