Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the preferred way of disconnecting / teardown? Is there one? #2

Closed
Akhetopnu opened this issue Jul 7, 2021 · 1 comment
Closed

Comments

@Akhetopnu
Copy link

As in the title - I don't see any function in the 'public API' of migratum:* responsible for that.

Is it assumed that users disassemble the provider and driver objects and then drop connection on their own? If not then can users be sure there will be no memory leaks when simply setting drivers connection to nil or discarding the object provided by `(migratum.provider.local-path:make-local-path-provider ...)?

There is no information about teardown in the docs/README.

@dnaeon
Copy link
Owner

dnaeon commented Jul 7, 2021

Hey @Akhetopnu ,

I've just added and documented the MIGRATUM:PROVIDER-SHUTDOWN and MIGRATUM:DRIVER-SHUTDOWN generic functions.

Please check them out and let me know if there's anything missing.

Thanks!

@dnaeon dnaeon closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants