Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Cannot notify user about registration when registration type is none #363

Closed
3 tasks done
valadas opened this issue Jan 25, 2019 · 2 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working pull request submitted
Milestone

Comments

@valadas
Copy link
Contributor

valadas commented Jan 25, 2019

Description of bug

When the registration type is none, creating a user and ticking the checkbox to notify him does not send an email to the user.

Steps to reproduce

List the steps to reproduce the behavior:

  1. In Security -> Member Accounts, set the registration type to none
  2. In Users, create a new user and tick the "Send an email to the new user" checkbox

Current result

The admin receives an email but not the user

Expected result

The user should receive the email

Additional context

This was previously discussed here dnnsoftware/Dnn.Platform#2424 and an inital PR #2492 was merged to bring the logic in to the core but the corresponding UI part needs to be updated to use this new method signature. The signature just accepts one additional bool parameter to notify the user or not and already checks the registration mode of the site to decide which email to send.

Affected version

  • 9.2.2
  • 9.2.1
  • 9.2
  • [?] 9.1.1
  • [?] 9.1
  • [?] 9.0
@valadas valadas added the bug Something isn't working label Jan 25, 2019
@valadas valadas added this to the 1.7.0 milestone Jan 25, 2019
@valadas valadas self-assigned this Jan 25, 2019
@valadas
Copy link
Contributor Author

valadas commented Jan 25, 2019

I will be submitting a PR for this shortly, working on it...

@valadas
Copy link
Contributor Author

valadas commented Jan 29, 2019

Closing manually, PR got merged

@valadas valadas closed this as completed Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working pull request submitted
Projects
None yet
Development

No branches or pull requests

1 participant