From 94107fbad941ad618bd5751eb14f4b6fe055e304 Mon Sep 17 00:00:00 2001 From: David Poindexter Date: Sun, 18 Oct 2020 02:38:03 -0400 Subject: [PATCH] Remove impractical rule @dnnsoftware/approvers I'm thinking this is a bit overkill, as I can't think of a reason why it would matter who actually clicks the merge button. The important thing is that there are two approvals. Do you all agree? --- .github/PULL_REQUEST_PROCESS.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_PROCESS.md b/.github/PULL_REQUEST_PROCESS.md index c2fbed66e7b..4d687fe176a 100644 --- a/.github/PULL_REQUEST_PROCESS.md +++ b/.github/PULL_REQUEST_PROCESS.md @@ -54,8 +54,6 @@ Examples of requests of this nature include technology or dependency changes tha ## Merging & Closing of Requests Once a pull request has been reviewed by two designated approvers it may be merged and the pull request closed. -> This **_MUST NOT_** be done by the submitter of the Pull Request for ANY reason! - ### Execption for Build Process Pull Requests A special exception has been granted to reduce the number of Designed Approval reviews to 1 for all pull requests related to Build Support when incrementing versions in prepration of a release, or reconfiguration of the environment for the next version. @@ -68,4 +66,4 @@ We follow the process outlined in the [Versioning Policy](VERSIONING_POLICY.md) The review team will work to respond to all pull requests in a timely fashion. If changes or additional information is requested a pull request will remain open allowing the submitter to update their contribution accordingly. If a request for additional information or changes is not completed with 90 days of request the Pull Request will be closed to keep the pipeline clear. Once the needed information has been gathered the information can be re-submitted via a new Pull Request. -For expedited processing you may reference the prior Pull Request. \ No newline at end of file +For expedited processing you may reference the prior Pull Request.