Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap priority 0 when adding a single page #3081

Closed
3 tasks done
valadas opened this issue Mar 1, 2019 · 6 comments · Fixed by #4441
Closed
3 tasks done

Sitemap priority 0 when adding a single page #3081

valadas opened this issue Mar 1, 2019 · 6 comments · Fixed by #4441

Comments

@valadas
Copy link
Contributor

valadas commented Mar 1, 2019

@schotman commented on Fri Mar 01 2019

Description of bug

When using the add a new page function in the pages dialog the SiteMapPriority is not set in the dialog and defaults to 0 in the database

Steps to reproduce

List the steps to reproduce the behavior:

  1. Go to pages
  2. Click on add page
  3. add pagename and
  4. click the add page button

Current result

SiteMapPriority = 0

Expected result

SiteMapPriority defaults to 0.5 (as it is when you add multiple pages)

Screenshots

seems clear

Error log

no error

Affected version

  • 9.2.2

Affected browser

not dependant of browser

  • Chrome
  • Firefox

@sleupold commented on Fri Mar 01 2019

IMO this should be fixed in DNN API code, not the database default value.


@Timo-Breumelhof commented on Fri Mar 01 2019

@skamphuis


@Timo-Breumelhof commented on Fri Mar 01 2019

workaround:

UPDATE TABS SET SiteMapPriority = 0.5 WHERE TABID IN (SELECT TabID
FROM Tabs
WHERE (PortalID = 0) AND (SiteMapPriority = 0) and (IsSystem = 0))


@schotman commented on Fri Mar 01 2019

IMO this should be fixed in DNN API code, not the database default value.

Yes, it should

@valadas
Copy link
Contributor Author

valadas commented Mar 1, 2019

The Persona Bar is defaulting to 0 and I can reproduce in 9.3.0 RC2 too.

@schotman
Copy link
Contributor

schotman commented Mar 2, 2019

one more thing.
When adding multiple pages: the SiteMapPriority is set to the value of the parent page, if there is no parent page it is set to 0.5. I think this makes sense

@valadas
Copy link
Contributor Author

valadas commented Apr 16, 2019

This needs to be retested, I think I put the "pull request submitted" by mistake on this one, I cannot find that PR now...

@valadas
Copy link
Contributor Author

valadas commented Oct 4, 2019

Just had a minute to test and this is still an issue in 9.4.1

@valadas valadas transferred this issue from dnnsoftware/Dnn.AdminExperience Oct 4, 2019
@valadas valadas added this to the 9.4.2 milestone Oct 4, 2019
@valadas valadas modified the milestones: 9.4.2, 9.4.3 Nov 5, 2019
@valadas valadas modified the milestones: 9.4.3, 9.5.0 Nov 21, 2019
@valadas valadas modified the milestones: 9.5.0, 9.5.1 Jan 30, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Mar 18, 2020
@valadas valadas modified the milestones: 9.6.0, 9.6.1 Apr 14, 2020
@valadas valadas modified the milestones: 9.6.1, 9.6.2 May 7, 2020
@valadas valadas modified the milestones: 9.6.2, 9.7.0 Jun 25, 2020
@valadas valadas removed this from the 9.7.0 milestone Jul 28, 2020
@valadas valadas added this to the Future: Patch milestone Jul 28, 2020
@Timo-Breumelhof
Copy link
Contributor

Still an issue in 9.8.0

@Tychodewaard
Copy link
Contributor

I can imagine that this is difficult to fix in API. If it is easier to fix it (at least temporarely) in the database, that would do. To explain the magnitude of the issue:
There have been several major projects where people did everything right (meta tags, content, Google search console etc) But everything was useless because the sitemappriority is 0. Even when it says 0.5 in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants