Remove Telerik Controls in HTML Editor

[SkyeHoefling]

Description of problem

In v10.0 of DNN the platform will be removing all instances of Telerik controls including the Telerik.Web.UI.dll from the bin directory. The HTML Editor takes a hard dependency on these controls through the deprecated web project which leverages the Telerik Controls. The entire Inline Editing toolbar for the HTML Editor module uses telerik controls. Those are not part of the CKEditor but Telerik.

The view code for inline editing

Dnn.Platform/DNN Platform/Modules/HTML/HtmlModule.ascx

Lines 8 to 21 in 8e17209

	<DNN:DNNToolBarButton ControlAction="edit" ID="tbEdit" ToolTip="Edit" CssClass="eipbutton_edit" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="save" ID="tbSave" ToolTip="Save" CssClass="eipbutton_save" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="cancel" ID="tbCancel" ToolTip="Cancel" CssClass="eipbutton_cancel" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="bold" ID="tbBold" ToolTip="Bold" CssClass="eipbutton_bold" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="italic" ID="tbItalic" ToolTip="Italic" CssClass="eipbutton_italic" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="underline" ID="tbUnderline" ToolTip="Underline" CssClass="eipbutton_underline" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="justifyleft" ID="tbJustifyLeft" ToolTip="JustifyLeft" CssClass="eipbutton_justifyleft" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="justifycenter" ID="tbJustifyCenter" ToolTip="JustifyCenter" CssClass="eipbutton_justifycenter" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="justifyright" ID="tbJustifyRight" ToolTip="JustifyRight" CssClass="eipbutton_justifyright" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="insertorderedlist" ID="tbOrderedList" ToolTip="OrderedList" CssClass="eipbutton_orderedlist" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="insertunorderedlist" ID="tbUnorderedList" ToolTip="UnorderedList" CssClass="eipbutton_unorderedlist" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="outdent" ID="tbOutdent" ToolTip="Outdent" CssClass="eipbutton_outdent" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="indent" ID="tbIndent" ToolTip="Indent" CssClass="eipbutton_indent" runat="server"/>
	<DNN:DNNToolBarButton ControlAction="createlink" ID="tbCreateLink" ToolTip="CreateLink" CssClass="eipbutton_createlink" runat="server"/>

The class definition for `DnnToolBarButton

Dnn.Platform/DNN Platform/DotNetNuke.Web.Deprecated/UI/WebControls/DnnToolBarButton.cs

Line 13 in 8e17209

public class DnnToolBarButton : RadToolBarButton

If these controls are not refactored prior to the v10 release inline editing will not function on any HTML Editor. Even if you use a custom HTML Editor Provider, the telerik controls are built right in to the view.

Description of solution

Remove all instances of telerik controls that are used in the HTML Editor Module

Description of alternatives considered

N/A

Screenshots

N/A

Additional context

N/A

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

[sleupold]

One option to solve this would be using CKEditor 4 in inline mode

[cklenk]

Would this potentially fix the issue I have with #3999?

[SkyeHoefling]

I don't think it would fix that. Your error message in #3999 cites a 404 error loading a js page. That appears to be an issue isolated to the Client Dependency Framework which minimizes the files and combines it into 1 js/css file

[valadas]

So interestingly InlineEditorEnabled is set to true by default on a clean install but inline editing does not show up, soooo what would be the plan here ? Do we simply kill the inline editing all together or what ?

[bdukes]

I'm not seeing this on my test site. I looked at this in #4142, and wasn't able to reproduce an issue. I just removed Telerik DLLs from my local and I still get working inline editing.

Am I missing something?

[bdukes]

Those controls in the HTML module are from DotNetNuke.WebControls, not DotNetNuke.Web.Deprecated

Dnn.Platform/DNN Platform/Modules/HTML/HtmlModule.ascx

Line 2 in ed13b35

<%@ Register TagPrefix="dnn" Namespace="DotNetNuke.UI.WebControls" Assembly="DotNetNuke.WebControls" %>

Which is apparently just a binary without source. 🤷🏻‍♂️

[SkyeHoefling]

I really don't remember much about my research on this, it was quite some time ago. Looks like it is something we can close as it appears what I thought was being used is not being used.

[valadas]

@bdukes I am curious, how do you get inline editing working on current version ?

[bdukes]

Nothing special, I just go into edit mode, and then when I mouse over the module content there's a pencil floating on the top left.

[valadas]

Oh, I kinda feel dumb now, I never used that lol. I thought it was only for the module title lol...

[bdukes]

😃

There is also one for the module title (if your container uses the title). It's a lot more useful for editing the title. Since editing the content uses contenteditable, there's a lot you can't control markup-wise. It's once of those nice features that can also cause you a lot of trouble.