Deleting connection Analytics removes all connectors

[Tychodewaard]

Description of bug

If you have a Google Analytics connection set up and you want to remove that connection, that is not possible.

1. You can not just remove the ua-code and hit save
2. if you choose 'delete connection', you destroy the Connectors part. The connections setting just says "Setup your connections to easily share content and more". So there is no Analytics and no Azure connectors anymore

Steps to reproduce

Go to COnnectors, save a ua-code, remove the ua-code (does not work) and click 'delete connection'.

Expected behavior

1. If I empty the ua-code field, I would like to be able to save that. Or have a 'reset-button;. But it must be possible to remove a ua-code.
2. whatever the 'delete connection' button is supposed to do, probably not this.

Error information

Message:Object reference not set to an instance of an object.

StackTrace:

at DNN.Connectors.GoogleAnalytics.GoogleAnalyticsConnector.GetConfig(Int32 portalId)
at DNN.Connectors.GoogleAnalytics.GoogleAnalyticsConnector.HasConfig(Int32 portalId)
at Dnn.PersonaBar.Connectors.Services.ConnectorsController.b__1_0(IConnector x)
at DotNetNuke.Collections.CollectionExtensions.ForEach[TType](IEnumerable1 source, Action1 action)
at Dnn.PersonaBar.Connectors.Services.ConnectorsController.GetConnections()
at lambda_method(Closure , Object , Object[] )
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass10.b__9(Object instance, Object[] methodParameters)
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.Execute(Object instance, Object[] arguments)
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ExecuteAsync(HttpControllerContext controllerContext, IDictionary2 arguments, CancellationToken cancellationToken) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Web.Http.Tracing.ITraceWriterExtensions.<TraceBeginEndAsyncCore>d__181.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Controllers.ApiControllerActionInvoker.d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Tracing.ITraceWriterExtensions.d__18`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Controllers.ActionFilterResult.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.AuthorizationFilterAttribute.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Controllers.ExceptionFilterResult.d__0.MoveNext()
InnerMessage:

InnerStackTrace:

Source:DNN.Connectors.GoogleAnalytics

Affected version

9.6.1 but as this part has not changed much, I think newer versions as well.

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[stale]

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

[skamphuis]

This issue is solved in #4457 as @Tychodewaard pointed out to me.