-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Build Process needs to not longer include- DotNetNuke.Telerik.Web
(DotNetNuke Telerik Web Components)- DigitalAssetsManagement
(Digital Asset Management)- DotNetNuke.Web.Deprecated
(DNN Deprecated Web Controls Library)- DotNetNuke.Website.Deprecated
(DNN Deprecated Website Codebehind files)
#4943
Comments
@mitchelsellers there are some places like Dnn.PersonaBar.Extensions that uses Telerik checks |
Those are checking that Telerik isn't installed, they already support the scenario where Telerik isn't there. |
@dnnsoftware/approvers are we removing these packages altogether, or only for installs? |
@bdukes this task is for the install build process, for which we are removing these pages altogether. Are you asking about the build process for the upgrade package? If so, good question. My vote would be to also not have these packages in the upgrade package. For those upgrading and wishing to keep Telerik, then they would already have it and wouldn't need these to be reinstalled or upgraded (as nothing would change). That said, I do see a scenario where this could be problematic for those upgrading from older versions of DNN to 9.11.0. They could potentially not get these upgraded if something has changed within them between their existing version and 9.11.0. So, perhaps this is worth a deeper conversation? |
Yeah, we should see when was the last time there was a meaningful change made to any of these packages, if our standard upgrade path would necessarily include that upgrade or not. |
Our recommended upgrade path would have us upgrading from 9.3.2 to 9.11.0. 9.2.1 includes a change for Telerik, this is the last meaningful change I see for the DotNetNuke.Telerik.Web package. 9.8.0 includes a change to remove the improvement program beacon from the old Control Bar (DotNetNuke.Website.Deprecated). 9.8.0 includes a change to mark the web controls as 9.8.1 includes a change for a move in the personalization API that touches the old Control Bar (DotNetNuke.Website.Deprecated). Do we want to update the recommended upgrade path to include 9.10.2 before 9.11.0 and go ahead and completely remove all of these packages? |
Thanks so much for the research @bdukes - upon further thought, I am thinking we do not remove these from the The major point of 9.11.0 was to ensure a clean install was forced to be Telerik-free. For upgrades, it should be optional so we do not introduce breaking changes. |
I would be of the opinion that we remove that (from upgrade package) on 10.0 IMO |
@mitchelsellers I know you had talked about a desire to say that DNN was "vulnerability-free" and weren't distributing Telerik at all. Does only distributing it via the Upgrade package meet that expectation? |
Yes I believe that meets the requirement as the upgrade is different. |
Done in #5212 |
No description provided.
The text was updated successfully, but these errors were encountered: