Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with larger category lists + large memory addons #86

Open
ryannotfound opened this issue Dec 2, 2022 · 0 comments
Open

Comments

@ryannotfound
Copy link

Low priority item here - but if loading Baggins with larger sorting configurations with even a relatively small addon list which consume a lot of memory (looking at ALL THE THINGS here...), it does appear that initial sorting can be incorrect. Workaround for this is to either re-open the container (this works for bank) or occasionally requires a full bag refresh if it's the player backpack.

For me personally, I can recreate this easily just by using the following addons:

  • ALL THE THINGS
  • Baggins
  • HandyNotes
  • HandyNotes: Shadowlands

When disabling ALL THE THINGS, I don't have this issue at all (even with my entire addon list loaded), and this of course is the largest memory addon in my loadout. This leads me to believe this is relating to addon memory usage in some way.

It also appears to only affect categories which overlap one another in some way but are sorted properly with use of the priority number. As an example, in my bank I have a trade goods bag, and then a trade goods bag for every past expansion which checks the original trade goods categories + an ilvl equal to that expansion's items (e.g. ilvl 10 for vanilla, 15 for TBC, 20 for WOTLK, etc..) with a higher priority than the generic trade goods categories. The current XPAC just uses the base trade goods categories since I don't do this kind of sorting in my inventory bags, just my bank, so this matches only DF items in my bank, but ALL items in my bags.

Here are some screenshots of the issue.

Before:
image

After:
image

Not sure if this is fixable, and it's not really a hassle to workaround it, but thought I'd mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant