Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Cannot Build Good CLI #74

Open
DGBernard opened this issue Jun 27, 2019 · 1 comment
Open

Cannot Build Good CLI #74

DGBernard opened this issue Jun 27, 2019 · 1 comment

Comments

@DGBernard
Copy link

Hi, i'm new to git/maven but have successful build of docbleach. The jar file corrupts every file I feed it. I have been using the last release / windows installer from December 2017 without issues, but wanted the new improvements. Files run through this current branch are 4K (for a docx that started as 2000K). No errors - output says file is good so i'm just copying it. Word says the file is corrupt and cannot be opened. Any ideas? Only issues during compile are 2 warnings:
[WARNING] Some problems were encountered while building the effective model for xyz.docbleach:cli:jar:0.0.1-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-jar-plugin is missing. @ line 89, column 15
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin is missing. @ line 133, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

and this: [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.

but, green build. Running the cli/target jar file.
I have asked a developer/coder to compile and we get the same results. Any help..... Thanks

@Jhoanor
Copy link
Contributor

Jhoanor commented Mar 17, 2020

The problem is in Bleachsession.java
Remove lines 69-71:
if (!bleach.handlesMagic(is)) {
return;
}
And it will work again.
In fact, is was the latest change to that file which broke it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants